[PATCH] 2.3.41 - cleanup file_operations structs

[Ingo Oeser]

On Sat, 29 Jan 2000, James Manning wrote:

> Changes:
> 	- updated to 2.3.41
> 	- cleaned up instances of leading spaces rather than tabs
> 	- removed some benign garbage added the first time
> 	- removed the 3 files from patch that were accepted
> 	  (arch/i386/kernel/apm.c, drivers/pci/proc.c, fs/udf/file.c)
> 	- file count is now down from 171 to 168 :)
> 	- 2429 LOC deleted - 980 LOC added = 1449 less kernel LOC
> 
> http://sublogic.com/patches/file_operations-2.3.41.patch

Nice patch. But why only file_operations? There are some/many
other struct-initializers that need the same optimization.

The only places, where we _shouln't_ do this, are places not
embedded in "#ifdef __KERNEL_"/"#endif /* __KERNEL__ */"
protections, because this _can_ be used from user code, which is
not required to use gcc (but kernel compilation is!).

This feature is not ANSI-C, so it is gcc specific.

Would you accept additional/incremental patches, to make this a
"better_struct_initializer"-patch?

Regards

Ingo Oeser
-- 
Feel the power of the penguin - run linux en your.pc
<esc>:x


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo en vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/