Constant byteorder macros.

[David Woodhouse]

> > NB: someone, somewhere, has put a cast to (long) in htonl, that I
> > preserved; but I think this is Wrong(tm), and if the htonl interface
> > is broken, then it

alan en lxorguk.ukuu.org.uk said:
> You are correct it is wrong. Its been removed in 2.2.x and I sent
> Linus the forward port of JJ's fix to 2.3.x a couple of days ago. 


htonl() itself is wrong, using the letter 'l' to denote something which isn't 
a long.

This is legacy stuff - so perhaps it should be left - although if it's not 
visible to user space I'm inclined to suggest that it should be fixed anyway. 

There's no real excuse for continuing to use [bwl] suffixes for other macros 
like PCI access, though - is there? 

--
dwmw2



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo en vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/